Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the incorrect tpcc result and v5 parameters #5473

Merged
merged 1 commit into from
Apr 25, 2021
Merged

fix the incorrect tpcc result and v5 parameters #5473

merged 1 commit into from
Apr 25, 2021

Conversation

dbsid
Copy link
Contributor

@dbsid dbsid commented Apr 25, 2021 •
edited
Loading

  1. fix the incorrect tpcc result
  2. add enable-request-batch: false
    for v5

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dbsid
fix the incorrect tpcc result change and v5 parameters
f820ef0 
1. fix the incorrect tpcc result
2. add enable-request-batch: false
 for v5
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Apr 25, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 25, 2021 08:50
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2021
@dbsid
Copy link
Contributor Author

dbsid commented Apr 25, 2021

/cc @3pointer @CaitinChen @CharLotteiu

@TomShawn
Copy link
Contributor

/cc @shuke987
/label needs-cherry-pick-5.0
/label require-LGT1
/translation doing
/assign Joyinqin

@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-5.0 labels Apr 25, 2021
@ti-chi-bot ti-chi-bot requested a review from shuke987 April 25, 2021 08:53
@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 25, 2021
@TomShawn
Copy link
Contributor

/uncc @3pointer @CaitinChen @CharLotteiu

@dbsid dbsid changed the title fix the incorrect tpcc result change and v5 parameters fix the incorrect tpcc resul and v5 parameters Apr 25, 2021
@shuke987
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@shuke987: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f820ef0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit 0ce9c82 into pingcap:master Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 25, 2021
@dbsid @ti-srebot
cherry pick pingcap#5473 to release-5.0
589c86e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5474

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
fix the incorrect tpcc resul and v5 parameters (#5473) (#5474)
e382e9c
@dbsid dbsid changed the title fix the incorrect tpcc resul and v5 parameters fix the incorrect tpcc result and v5 parameters Apr 25, 2021
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done
/unassign @Joyinqin
/assign @dbsid

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 25, 2021
@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 25, 2021
@TomShawn TomShawn mentioned this pull request Apr 25, 2021
Merged
11 tasks
youjiali1995
youjiali1995 reviewed Apr 25, 2021
View reviewed changes
benchmark/benchmark-sysbench-v5-vs-v4.md
@@ -87,6 +87,7 @@ readpool.unified.min-thread-count: 5
readpool.unified.max-thread-count: 20
readpool.storage.normal-concurrency: 10
pessimistic-txn.pipelined: true
enable-request-batch: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server.enable-request-batch: false

@TomShawn
Copy link
Contributor

/label requires-followup
Follow-up: resolve #5473 (comment)

@ti-chi-bot ti-chi-bot added the requires-followup This PR requires a follow-up task after being merged. label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 left review comments

@TomShawn TomShawn Awaiting requested review from TomShawn

@shuke987 shuke987 Awaiting requested review from shuke987

Assignees

@dbsid dbsid

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. requires-followup This PR requires a follow-up task after being merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dbsid @TomShawn @shuke987 @ti-chi-bot @ti-srebot @youjiali1995 @Joyinqin