Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify telemetry on Dashboard #5425

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Clarify telemetry on Dashboard #5425

merged 2 commits into from
Apr 25, 2021

Conversation

cncc
Copy link

@cncc cncc commented Apr 22, 2021

To clarify, you can't enable/disable telemetry on Dashboard

First-time contributors' checklist

What is changed, added or deleted? (Required)

To clarify that, you can't enable/disable telemetry from dashboard now.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@cncc
Clarify telemetry on Dashboard
cd272dd 
To clarify, you can't enable/disable telemetry on Dashboard
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Apr 22, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 22, 2021 02:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 22, 2021 •
edited
Loading

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/remove-translation doing
/translation no-need
/cc @breeswish

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: Liuxiaozhen12.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/translation doing
/cc @Liuxiaozhen12
/cc @breeswish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 22, 2021
@ti-chi-bot ti-chi-bot requested a review from breezewish April 22, 2021 02:57
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 22, 2021
@breezewish
Copy link
Member

breezewish commented Apr 22, 2021 •
edited
Loading

I think the understanding is incorrect. This configuration is a configuration for TiDB Dashboard, not for TiDB. It's just not a GUI.

@cncc
To better describe this configuration
3cc81be 
dashboard.enable-telemetry
@TomShawn
Copy link
Contributor

@breeswish PTAL again. Thanks!

breezewish
breezewish approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: The label(s) translation/np-need cannot be applied, because the repository doesn't have them.

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/translation np-need
/cc @breeswish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3cc81be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit f751019 into pingcap:release-4.0 Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 25, 2021
@cncc @ti-srebot
cherry pick pingcap#5425 to release-5.0
f0d4b18 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5469

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 25, 2021
@cncc @ti-srebot
cherry pick pingcap#5425 to master
2175f49 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5470

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
Clarify telemetry on Dashboard (#5425) (#5469)
b1768b4
ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
Clarify telemetry on Dashboard (#5425) (#5470)
5a279a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cncc @CLAassistant @TomShawn @ti-chi-bot @breezewish @ti-srebot