Skip to content

geo-distributed-deployment-topology: Explain dc and zone names #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2021
Merged

geo-distributed-deployment-topology: Explain dc and zone names #5311

merged 3 commits into from
May 7, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 13, 2021

What is changed, added or deleted? (Required)

This should help the reader to better understand the example
and by also linking to the document about labels this provide further
information if needed.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

/label version-specific-changes-required

@dveeden
geo-distributed-deployment-topology: Explain what dc and zone names
ded8ab0 
This should help the reader to better understand the example
and by also linking to the document about labels this provide further
information if needed.
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021
@TomShawn
Copy link
Contributor

/cc @superlzs0476 @King-Dylan
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL
/translation doing
/assign Joyinqin

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Apr 14, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: superlzs0476.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @superlzs0476 @King-Dylan
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL
/translation doing
/assign Joyinqin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 14, 2021
@ti-chi-bot ti-chi-bot requested a review from King-Dylan April 14, 2021 02:35
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@TomShawn
Copy link
Contributor

/cc @superlzs0476

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: superlzs0476.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @superlzs0476

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TomShawn
TomShawn reviewed Apr 26, 2021
View reviewed changes
@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Contributor

@King-Dylan @superlzs0476 PTAL this PR. Shall we modify the example to use city names of the US?

@lucklove
Copy link
Member

lucklove commented May 6, 2021

/lgtm

@dveeden @TomShawn
Update geo-distributed-deployment-topology.md
f462593 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed May 6, 2021
View reviewed changes
@dveeden @TomShawn
Update geo-distributed-deployment-topology.md
6a973c8 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented May 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a973c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2021
@ti-chi-bot ti-chi-bot merged commit 2b501f3 into pingcap:master May 7, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 7, 2021
@dveeden @ti-srebot
cherry pick pingcap#5311 to release-4.0
20bec96 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 7, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5583

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 7, 2021
@dveeden @ti-srebot
cherry pick pingcap#5311 to release-5.0
4b082c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 7, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5584

ti-chi-bot pushed a commit that referenced this pull request May 7, 2021
@ti-srebot
geo-distributed-deployment-topology: Explain dc and zone names (#5311) (
4859a9d 
#5583)
ti-chi-bot pushed a commit that referenced this pull request May 7, 2021
@ti-srebot
geo-distributed-deployment-topology: Explain dc and zone names (#5311) (
fceb6fa 
#5584)
@Joyinqin Joyinqin mentioned this pull request May 7, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented May 7, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 7, 2021
This was referenced May 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dveeden @TomShawn @ti-chi-bot @lucklove @ti-srebot @Joyinqin