Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiUP: Add three docs about tiup dm display, upgrade, and cluster check #5291

Merged
merged 17 commits into from
Apr 16, 2021
Merged

TiUP: Add three docs about tiup dm display, upgrade, and cluster check #5291

merged 17 commits into from
Apr 16, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 12, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 12, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2021
@qiancai qiancai changed the title TiUP: Add two docs about tiup dm display and upgrade TiUP: Add three docs about tiup dm display, upgrade, and cluster check Apr 13, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 13, 2021
Merged
11 tasks
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 14, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/label require-LGT1
/cc @lucklove

@ti-chi-bot ti-chi-bot requested a review from lucklove April 14, 2021 02:38
@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. labels Apr 14, 2021
@Joyinqin
Copy link
Contributor

/cc @CharLotteiu

@ti-chi-bot ti-chi-bot requested a review from CharLotteiu April 14, 2021 06:01
CharLotteiu
CharLotteiu reviewed Apr 14, 2021
View reviewed changes
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai @CharLotteiu
Update tiup/tiup-component-cluster-check.md
4ac119b 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
qiancai
qiancai commented Apr 16, 2021
View reviewed changes
qiancai and others added 3 commits April 16, 2021 10:45
@qiancai
Update tiup/tiup-component-cluster-check.md
f841f70
@qiancai @CharLotteiu
Update tiup/tiup-component-cluster-check.md
7cba391 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@qiancai @CharLotteiu
Apply suggestions from code review
98a4a31 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
qiancai
qiancai commented Apr 16, 2021
View reviewed changes
tiup/tiup-component-dm-display.md Outdated
tiup dm display <cluster-name> [flags]
```

`<cluster-name>` is the name of the cluster to operate on. If you forget the cluster name, check it in [tiup cluster list](/tiup/tiup-component-cluster-list.md).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`<cluster-name>` is the name of the cluster to operate on. If you forget the cluster name, check it in [tiup cluster list](/tiup/tiup-component-cluster-list.md).
`<cluster-name>` is the name of the cluster to operate on. If you forget the cluster name, you can check it using the `[tiup cluster list](/tiup/tiup-component-cluster-list.md)` command.

qiancai
qiancai commented Apr 16, 2021
View reviewed changes
@qiancai @CharLotteiu
Apply suggestions from code review
ec72a05 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu
Copy link
Contributor

/remove-require LGT1

CharLotteiu
CharLotteiu reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change these contents to lists to pass the manual line break CI check.

@qiancai @CharLotteiu
Apply suggestions from code review
1e037c2 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
qiancai and others added 3 commits April 16, 2021 16:55
@qiancai
Merge remote-tracking branch 'upstream/master' into TiUP-translate-dm…
42f1f06 
…-display-and-dm-list
@qiancai
Merge branch 'TiUP-translate-dm-display-and-dm-list' of https://githu…
9016499 
…b.com/qiancai/docs into TiUP-translate-dm-display-and-dm-list
@qiancai @CharLotteiu
Update tiup/tiup-component-dm-display.md
39a9096 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu
Copy link
Contributor

/lgtm

@CharLotteiu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39a9096

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 4fd20fa into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5291 to release-4.0
5371d66 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5361

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5291 to release-5.0
f08f855 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5362

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: Add three docs about tiup dm display, upgrade, and cluster check (
232017f 
#5291) (#5361)
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: Add three docs about tiup dm display, upgrade, and cluster check (
a25da5d 
#5291) (#5362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu left review comments

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qiancai @Joyinqin @lucklove @ti-chi-bot @CharLotteiu @ti-srebot @AstroProfundis