Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: generalize and link to the external storage docs from Lightning #5286

Merged
merged 5 commits into from
Apr 13, 2021
Merged

*: generalize and link to the external storage docs from Lightning #5286

merged 5 commits into from
Apr 13, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 12, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Fix #4445.

Generalize the "BR storage" page to "external storage", and talk about all associated migration services.

Link back to this page from their documents.

Follow-up: Change the file name for 外部存储 and remove it out of /br. @IANTHEREAL will work on its new position in TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions) Have version-specific changes
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2021
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/translation from-docs-cn
/cc @yikeke @overvenus @IANTHEREAL

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@TomShawn
Copy link
Contributor Author

/label requires-version-specific-change

@ti-chi-bot
Copy link
Member

@TomShawn: The label(s) requires-version-specific-change cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/label requires-version-specific-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 12, 2021
@TomShawn
Copy link
Contributor Author

/label requires-followup

@ti-chi-bot ti-chi-bot added the requires-followup This PR requires a follow-up task after being merged. label Apr 12, 2021
IANTHEREAL
IANTHEREAL reviewed Apr 12, 2021
View reviewed changes
tidb-lightning/tidb-lightning-overview.md Outdated
Currently, TiDB Lightning supports:

- The data source of the [Dumpling](/dumpling-overview.md), CSV or [Amazon Aurora Parquet](/migrate-from-aurora-using-lightning.md) exported formats.
- Reading data from a local disk or from the Amazon S3 storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it link to external storage introduction？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@IANTHEREAL
Copy link
Contributor

Rest LGTM

@TomShawn @kennytm
Update br/backup-and-restore-storages.md
c184968 
Co-authored-by: kennytm <kennytm@gmail.com>
@yikeke
Copy link
Contributor

yikeke commented Apr 12, 2021

New feature: Now all the docs repositories support labeling sig/xxx to give the review privileges to the SIG's reviewers.

Do you know which SIG the PR changes belong to? @kennytm

yikeke
yikeke reviewed Apr 13, 2021
View reviewed changes
dumpling-overview.md Outdated Show resolved Hide resolved
yikeke
yikeke reviewed Apr 13, 2021
View reviewed changes
sql-statements/sql-statement-backup.md
@@ -98,7 +98,7 @@ BACKUP DATABASE * TO 'local:///mnt/backup/full/';

Note that the system tables (`mysql.*`, `INFORMATION_SCHEMA.*`, `PERFORMANCE_SCHEMA.*`, …) will not be included into the backup.

### Remote destinations
### External storages

BR supports backing up data to S3 or GCS:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the Line 111: BR storages -> external storages

And the same for the Chinese version.

Copy link
Contributor Author

@TomShawn TomShawn Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 913a840

yikeke
yikeke reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest /lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
TomShawn and others added 2 commits April 13, 2021 11:16
@TomShawn @yikeke
Apply suggestions from code review
7f98b30 
Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>
@TomShawn
br storages --> external storages
913a840
@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

PTAL again @kennytm

@kennytm
Copy link
Contributor

kennytm commented Apr 13, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@kennytm: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 913a840

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 3f76f22 into pingcap:master Apr 13, 2021
@TomShawn TomShawn deleted the storage-paramms-to-lightbing branch April 13, 2021 10:09
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 13, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5286 to release-4.0
9433e7b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5315

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 13, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5286 to release-5.0
8fff74c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5316

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
*: generalize and link to the external storage docs from Lightning (#…
4f52d6f 
…5286) (#5316)
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
*: generalize and link to the external storage docs from Lightning (#…
b247fdc 
…5286) (#5315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@kennytm kennytm kennytm left review comments

@yikeke yikeke yikeke approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
requires-followup This PR requires a follow-up task after being merged. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TomShawn @ti-chi-bot @IANTHEREAL @yikeke @kennytm @ti-srebot