Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiUP: add three docs for cluster start, stop, and more info #5277

Merged
merged 24 commits into from
Apr 16, 2021
Merged

TiUP: add three docs for cluster start, stop, and more info #5277

merged 24 commits into from
Apr 16, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 9, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 9, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 9, 2021
@qiancai qiancai changed the title TiUP: add three docs for cluster start, stop, and more info [WIP] TiUP: add three docs for cluster start, stop, and more info Apr 9, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2021
@qiancai qiancai changed the title [WIP] TiUP: add three docs for cluster start, stop, and more info TiUP: add three docs for cluster start, stop, and more info Apr 12, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 14, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/label require-LGT1
/cc @lucklove

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. labels Apr 14, 2021
@Joyinqin
Copy link
Contributor

/cc @Joyinqin

Joyinqin
Joyinqin reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

tiup/tiup-component-cluster-start.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-start.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-start.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-start.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-start.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits April 15, 2021 15:17
@qiancai @Joyinqin
Update tiup/tiup-component-cluster-start.md
74f8b7c 
Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@qiancai @Joyinqin
Update tiup/tiup-component-cluster-start.md
b113edc 
Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@lucklove
Copy link
Member

rest lgtm

@qiancai @lucklove
Apply suggestions from code review
213c32f 
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@Joyinqin
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 213c32f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 9a7305e into pingcap:master Apr 16, 2021
@TomShawn
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5277 to release-4.0
6c84646 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5365

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5277 to release-5.0
3b9b115 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5366

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: add three docs for cluster start, stop, and more info (#5277) (#…
bb8ac5f 
…5366)
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: add three docs for cluster start, stop, and more info (#5277) (#…
1e549ce 
…5365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove left review comments

@TomShawn TomShawn TomShawn left review comments

@Joyinqin Joyinqin Joyinqin left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiancai @Joyinqin @lucklove @ti-chi-bot @TomShawn @ti-srebot