Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the New in v5.0 mark in system-variables.md #5276

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Add the New in v5.0 mark in system-variables.md #5276

merged 2 commits into from
Apr 13, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 9, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the New in v5.0 mark to three system variables that are introduced in 5.0.

  • tidb_opt_prefer_range_scan
  • tidb_skip_ascii_check
  • tidb_mem_quota_apply_cache

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/label needs-cherry-pick-5.0
/label v5.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/translation doing

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 9, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 9, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/remove-translation from-docs-cn

@ti-chi-bot ti-chi-bot removed the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/cc @yikeke @TomShawn

@ti-chi-bot ti-chi-bot requested review from TomShawn and yikeke April 9, 2021 07:14
@yikeke yikeke removed the request for review from TomShawn April 9, 2021 07:30
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/cc @bb7133 @glkappe

@ti-chi-bot ti-chi-bot requested review from bb7133 and glkappe April 9, 2021 07:33
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@yikeke yikeke added require-LGT1 Indicates that the PR requires an LGTM. and removed require-LGT1 Indicates that the PR requires an LGTM. labels Apr 9, 2021
@glkappe
Copy link

glkappe commented Apr 13, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glkappe
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16533da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 1cf5980 into pingcap:master Apr 13, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 13, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5276 to release-5.0
92db9e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5296

@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Add the New in v5.0 mark in system-variables.md (#5276) (#5296)
fdfe84d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@glkappe glkappe Awaiting requested review from glkappe

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @glkappe @ti-chi-bot @yikeke @ti-srebot