Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the EN version of the Benchmark reports #5255

Merged
merged 14 commits into from
Apr 7, 2021
Merged

Added the EN version of the Benchmark reports #5255

merged 14 commits into from
Apr 7, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 7, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the benchmark reports (Sysbench and TPC-C) for v5.0 GA.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 7, 2021

/translation from-docs-cn
/label v5.0
/label needs-cherry-pick-5.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 7, 2021

/cc @TomShawn @shuke987

@ti-chi-bot ti-chi-bot requested review from shuke987 and TomShawn April 7, 2021 10:32
TomShawn
TomShawn reviewed Apr 7, 2021
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5-vs-v4.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5-vs-v4.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5-vs-v4.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5-vs-v4.md Outdated Show resolved Hide resolved
benchmark/v5.0-performance-benchmarking-with-tpcc.md Outdated Show resolved Hide resolved
@qiancai @TomShawn
Update TOC.md
539c46e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2021
qiancai and others added 6 commits April 7, 2021 20:21
@qiancai @TomShawn
Update TOC.md
ae4263b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update benchmark/benchmark-sysbench-v5-vs-v4.md
899e202 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update benchmark/benchmark-sysbench-v5-vs-v4.md
7ef963a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update benchmark/benchmark-sysbench-v5-vs-v4.md
04e329a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update benchmark/v5.0-performance-benchmarking-with-tpcc.md
c0931fe 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update benchmark/benchmark-sysbench-v5-vs-v4.md
4e5ca51 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

@qiancai Please resolve the conflict by aligning the TOC with
image

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 7, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c0ee786

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
shuke987
shuke987 reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit f87307f into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@qiancai @ti-srebot
cherry pick pingcap#5255 to release-5.0
64771b7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5261

yikeke pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot @qiancai
cherry pick #5255 to release-5.0 (#5261)
22a2b12 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Grace Cai <qqzczy@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@shuke987 shuke987 shuke987 left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiancai @TomShawn @ti-chi-bot @ti-srebot @shuke987