Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine TiFlash doc to add executor pushdown white list #5245

Merged
merged 3 commits into from
Apr 7, 2021
Merged

refine TiFlash doc to add executor pushdown white list #5245

merged 3 commits into from
Apr 7, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 7, 2021

What is changed, added or deleted? (Required)

refine TiFlash doc to add executor pushdown white list

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 7, 2021

/translation from-docs-cn
/label needs-cherry-pick-5.0
/cc @qiancai @windtalker @Joyinqin
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2021
windtalker
windtalker reviewed Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated
* TableScan: Reads data from tables.
* Selection: Filters data.
* HashAgg: Performs data aggregation based on the [Hash Aggregation](/explain-aggregation.md#hash-aggregation) algorithm.
* StreamAgg: Performs data aggregation based on the [Stream Aggregation](/explain-aggregation.md#stream-aggregation) algorithm. SteamAgg only supports the column without the `GROUP BY` condition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SteamAgg only supports the column without the => SteamAgg only supports the aggregation without the

TomShawn
TomShawn commented Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
@windtalker
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@windtalker: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai
qiancai reviewed Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Apr 7, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
@TomShawn @qiancai
Apply suggestions from code review
4752293 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Copy link
Collaborator

qiancai commented Apr 7, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 7, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Joyinqin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4752293

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit 0daa729 into pingcap:master Apr 7, 2021
@TomShawn TomShawn deleted the executor-pushdown-white-list branch April 7, 2021 09:00
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5245 to release-5.0
14f4ce7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5248

ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
refine TiFlash doc to add executor pushdown white list (#5245) (#5248)
3e0bd0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@windtalker windtalker windtalker left review comments

@Joyinqin Joyinqin Awaiting requested review from Joyinqin

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TomShawn @windtalker @ti-chi-bot @qiancai @Joyinqin @ti-srebot