Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TPC-H 100GB on TiDB 5.0 with MPP benchmark #5244

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Add TPC-H 100GB on TiDB 5.0 with MPP benchmark #5244

merged 5 commits into from
Apr 7, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add TiDB v5.0 MPP benchmark, which is compared with Greenplum and Apache Spark.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @qiancai @ilovesoup

@ti-chi-bot
Copy link
Member

@CharLotteiu: GitHub didn't allow me to request PR reviews from the following users: ilovesoup.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/label needs-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @qiancai @ilovesoup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from qiancai April 7, 2021 08:08
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2021
@CharLotteiu
Copy link
Contributor Author

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 7, 2021 08:22
TomShawn
TomShawn approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

benchmark/v5.0-performance-benchmarking-with-tpch.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
yikeke
yikeke reviewed Apr 7, 2021
View reviewed changes
TOC.md
@@ -9,7 +9,9 @@
+ [TiDB Introduction](/overview.md)
+ [What's New in TiDB 5.0](/releases/release-5.0.0-rc.md)
+ [Basic Features](/basic-features.md)
+ [Experimental Features](/experimental-features.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add this in another PR. Please take it together.

@CharLotteiu
Copy link
Contributor Author

/rebase

CharLotteiu and others added 4 commits April 7, 2021 09:43
@CharLotteiu
add tpch benchmark
c24e3e2
@CharLotteiu @TomShawn @qiancai
Apply suggestions from code review
0a4d4d3 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@CharLotteiu
Update TOC.md
e78d820
@CharLotteiu
Apply suggestions from code review
1461c2c
@CharLotteiu @ilovesoup
Apply suggestions from code review
ddaf352 
Co-authored-by: Soup <maxiaoyu@pingcap.com>
zanmato1984
zanmato1984 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zanmato1984: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Contributor Author

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 7, 2021
@CharLotteiu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ddaf352

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit e40100a into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5244 to release-5.0
8eedf68 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5257

ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
Add TPC-H 100GB on TiDB 5.0 with MPP benchmark (#5244) (#5257)
95a5e66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@yikeke yikeke yikeke left review comments

@ilovesoup ilovesoup ilovesoup left review comments

@TomShawn TomShawn TomShawn approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@CharLotteiu @ti-chi-bot @ti-srebot @zanmato1984 @ilovesoup @yikeke @TomShawn @qiancai