Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hardware-and-software-requirements.md #5228

Merged
merged 1 commit into from
May 6, 2021
Merged

Update hardware-and-software-requirements.md #5228

merged 1 commit into from
May 6, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 6, 2021

What is changed, added or deleted? (Required)

On a minimal install of CentOS 8 tar is not installed. This causes TiUP deployments to fail.

So add tar to the list of prerequisites

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

/label version-specific-changes-required

@dveeden
Update hardware-and-software-requirements.md
45d1956 
On a minimal install of CentOS 8 tar is not installed. This causes TiUP deployments to fail.

So add `tar` to the list of prerequisites
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2021
@morgo morgo mentioned this pull request Apr 6, 2021
Closed
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/cc @morgo @King-Dylan @lucklove
/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/assign Joyinqin
/translation doing

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 7, 2021
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2021
@lucklove
Copy link
Member

lucklove commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@lilyjazz
Copy link
Member

lilyjazz commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@lilyjazz: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented May 6, 2021

/lgtm

@TomShawn
Copy link
Contributor

TomShawn commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45d1956

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@ti-chi-bot ti-chi-bot merged commit 766c50d into pingcap:release-4.0 May 6, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 6, 2021
@dveeden @ti-srebot
cherry pick pingcap#5228 to release-5.0
aaeea17 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5578

@ti-srebot ti-srebot mentioned this pull request May 6, 2021
Merged
10 tasks
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 6, 2021
@dveeden @ti-srebot
cherry pick pingcap#5228 to master
81a3178 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5579

ti-chi-bot pushed a commit that referenced this pull request May 6, 2021
@ti-srebot
Update hardware-and-software-requirements.md (#5228) (#5578)
e646313
ti-chi-bot pushed a commit that referenced this pull request May 6, 2021
@ti-srebot
Update hardware-and-software-requirements.md (#5228) (#5579)
ba07f8f
@Joyinqin Joyinqin mentioned this pull request May 7, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented May 7, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 7, 2021
This was referenced May 7, 2021
Merged
Merged
@dveeden dveeden mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

@lucklove lucklove Awaiting requested review from lucklove

@morgo morgo Awaiting requested review from morgo

Assignees

@Joyinqin Joyinqin

Labels
needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dveeden @TomShawn @lucklove @ti-chi-bot @lilyjazz @ti-srebot @Joyinqin