Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in tiup-cluster.md #5202

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix typos in tiup-cluster.md #5202

merged 1 commit into from
Apr 21, 2021

Conversation

rkazak
Copy link

@rkazak rkazak commented Apr 3, 2021 •
edited
Loading

minor typo -

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/status PTAL
/cc @lucklove
/label require-LGT1
/assign Joyinqin

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Apr 6, 2021
@ti-chi-bot ti-chi-bot requested a review from lucklove April 6, 2021 05:59
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. require-LGT1 Indicates that the PR requires an LGTM. labels Apr 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/retitle Fix typos in tiup-cluster.md

@ti-chi-bot ti-chi-bot changed the title Update tiup-cluster.md Fix typos in tiup-cluster.md Apr 6, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e10a211

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@ti-chi-bot ti-chi-bot merged commit c391b7c into pingcap:release-4.0 Apr 21, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 21, 2021
@rkazak @ti-srebot
cherry pick pingcap#5202 to release-5.0
5fd8964 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5417

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 21, 2021
@rkazak @ti-srebot
cherry pick pingcap#5202 to master
11a6598 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5418

ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2021
@ti-srebot
Fix typos in tiup-cluster.md (#5202) (#5418)
ee17a64
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2021
@ti-srebot
Fix typos in tiup-cluster.md (#5202) (#5417)
3553044
@Joyinqin
Copy link
Contributor

/translation doing

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 23, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 23, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 23, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 23, 2021
This was referenced Apr 23, 2021
Merged
Merged
@rkazak rkazak deleted the patch-2 branch July 12, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@Joyinqin Joyinqin

Labels
needs-cherry-pick-master Should cherry pick this PR to master branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkazak @TomShawn @lucklove @ti-chi-bot @ti-srebot @Joyinqin