Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the descriptions of BR, telemetry, hot spot issues, and TiKV thread pool for 5.0 GA #5194

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Update the descriptions of BR, telemetry, hot spot issues, and TiKV thread pool for 5.0 GA #5194

merged 6 commits into from
Apr 6, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 2, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Minor changes on version-specific info

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 2, 2021

/translation from-docs-cn
/label needs-cherry-pick-5.0
/label v5.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Apr 2, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 2, 2021

/cc @Damon-Guo @ lilyjazz @ overvenus

@qiancai
Copy link
Collaborator Author

qiancai commented Apr 2, 2021

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 2, 2021 08:12
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 2, 2021

/cc @Damon-Guo @lilyjazz @overvenus

@ti-chi-bot
Copy link
Member

@qiancai: GitHub didn't allow me to request PR reviews from the following users: lilyjazz.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Damon-Guo @lilyjazz @overvenus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai changed the title Update troubleshoot-hot-spot-issues.md Update the descriptions of BR, telemetry, and hot spot issues for 5.0 GA Apr 2, 2021
@Damon-Guo
Copy link

LGTM

@overvenus
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2021
@qiancai qiancai changed the title Update the descriptions of BR, telemetry, and hot spot issues for 5.0 GA Update the descriptions of BR, telemetry, hot spot issues, and TiKV thread pool for 5.0 GA Apr 2, 2021
Little-Wallace
Little-Wallace approved these changes Apr 2, 2021
View reviewed changes
Copy link

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@Little-Wallace: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Apr 2, 2021
View reviewed changes
telemetry.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Apr 2, 2021 •
edited
Loading

rest /lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 2, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2021
qiancai and others added 2 commits April 6, 2021 13:20
@qiancai @TomShawn
Update telemetry.md
6eec4b2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update tune-tikv-thread-performance.md
d840bc5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 6, 2021

/cc @lilyjazz

@ti-chi-bot ti-chi-bot requested a review from lilyjazz April 6, 2021 05:23
@lilyjazz
Copy link
Member

lilyjazz commented Apr 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@lilyjazz: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d840bc5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2021
@ti-chi-bot ti-chi-bot merged commit 40908c7 into pingcap:master Apr 6, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 6, 2021
@qiancai @ti-srebot
cherry pick pingcap#5194 to release-5.0
3dc3b8d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 6, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5211

ti-chi-bot pushed a commit that referenced this pull request Apr 6, 2021
@ti-srebot
Update the descriptions of BR, telemetry, hot spot issues, and TiKV t…
c0059ec 
…hread pool for 5.0 GA (#5194) (#5211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@Little-Wallace Little-Wallace Little-Wallace approved these changes

@overvenus overvenus Awaiting requested review from overvenus

@Damon-Guo Damon-Guo Awaiting requested review from Damon-Guo

@lilyjazz lilyjazz Awaiting requested review from lilyjazz

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qiancai @ti-chi-bot @Damon-Guo @overvenus @TomShawn @lilyjazz @ti-srebot @Little-Wallace