Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update async commit related documentation #5114

Merged
merged 3 commits into from
Mar 26, 2021
Merged

update async commit related documentation #5114

merged 3 commits into from
Mar 26, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 25, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

TiDB 5.0 GA will not contain configurations related to async commit or 1PC. So they are removed.

And we also introduce a weaker consistency model for transactions. Add documentation about it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2021
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label requires-version-specific-changes
/label v5.0
/translation from-docs-cn
/cc @sticnarf @ran-huang

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021
ran-huang
ran-huang reviewed Mar 25, 2021
View reviewed changes
transaction-overview.md Outdated Show resolved Hide resolved
@TomShawn @ran-huang
Update transaction-overview.md
6c19bb6 
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@qiancai
Copy link
Collaborator

qiancai commented Mar 26, 2021

/cc @youjiali1995

@ti-chi-bot ti-chi-bot requested a review from youjiali1995 March 26, 2021 05:47
youjiali1995
youjiali1995 reviewed Mar 26, 2021
View reviewed changes
Copy link

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TomShawn
Copy link
Contributor Author

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 26, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6c19bb6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@ti-chi-bot ti-chi-bot merged commit 8750fd7 into pingcap:master Mar 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 26, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5114 to release-5.0
0b6ee9a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5131

@TomShawn TomShawn deleted the async-commit-5.0-ga branch March 26, 2021 08:54
ti-chi-bot pushed a commit that referenced this pull request Mar 26, 2021
@ti-srebot
update async commit related documentation (#5114) (#5131)
8859bbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@youjiali1995 youjiali1995 youjiali1995 left review comments

@sticnarf sticnarf Awaiting requested review from sticnarf

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TomShawn @ran-huang @ti-chi-bot @qiancai @ti-srebot @youjiali1995