Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL variables: add a new variable tidb_enable_parallel_apply #5092

Merged
merged 7 commits into from
Mar 25, 2021
Merged

SQL variables: add a new variable tidb_enable_parallel_apply #5092

merged 7 commits into from
Mar 25, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label v5.0

@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. labels Mar 24, 2021
@Joyinqin
Copy link
Contributor Author

/cc @qw4990 @TomShawn

@ti-chi-bot ti-chi-bot requested review from qw4990 and TomShawn March 24, 2021 06:29
@ti-chi-bot
Copy link
Member

@qw4990: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Mar 25, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@qw4990: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Joyinqin @TomShawn
Apply suggestions from code review
35f0ae4 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
system-variables.md Outdated

- Scope: SESSION | GLOBAL
- Default value: 0
- This variable controls whether to enable the Apply operator concurrency, and the number of concurrency is controlled by the `tidb_executor_concurrency` variable. The Apply operator is used to process correlated subqueries and has no concurrency by default, so the execution speed is slow. Enable the Apply concurrency switch can increase concurrency and speed up execution. Currently, this variable defaults to be disabled.
Copy link
Contributor

@TomShawn TomShawn Mar 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- This variable controls whether to enable the Apply operator concurrency, and the number of concurrency is controlled by the `tidb_executor_concurrency` variable. The Apply operator is used to process correlated subqueries and has no concurrency by default, so the execution speed is slow. Enable the Apply concurrency switch can increase concurrency and speed up execution. Currently, this variable defaults to be disabled.
- This variable controls whether to enable concurrency for the `Apply` operator. The number of concurrencies is controlled by the `tidb_executor_concurrency` variable. The `Apply` operator processes correlated subqueries and has no concurrency by default, so the execution speed is slow. Setting this variable value to `1` can increase concurrency and speed up execution. Currently, concurrency for `Apply` is disabled by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joyinqin Please see this comment.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021
TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Joyinqin @TomShawn
Apply suggestions from code review
05c1e36 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021
@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 25, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a56f022

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 8c6b916 into pingcap:master Mar 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 25, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5092 to release-5.0
a6c8e91 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5120

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021
@ti-srebot
SQL variables: add a new variable tidb_enable_parallel_apply (#5092) (
ae00f2f 
#5120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @ti-chi-bot @qw4990 @TomShawn @ti-srebot