Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add three docs #5061

Merged
merged 9 commits into from
Apr 1, 2021
Merged

tiup: add three docs #5061

merged 9 commits into from
Apr 1, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add 3 docs:

  • tiup/tiup-command-telemetry.md
  • tiup/tiup-component-cluster-destroy.md
  • tiup/tiup-component-cluster-audit.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-4.0

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 18, 2021
@Joyinqin
Copy link
Contributor Author

/cc CharLotteiu
/cc lucklove

@Joyinqin Joyinqin marked this pull request as ready for review March 22, 2021 10:05
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@yikeke yikeke requested review from ran-huang and removed request for CharLotteiu March 31, 2021 02:12
@yikeke yikeke added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 31, 2021
ran-huang
ran-huang reviewed Mar 31, 2021
View reviewed changes
tiup/tiup-command-telemetry.md
@@ -0,0 +1,54 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No TOC?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all en TiUP docs in pingcap/docs-cn#4868 is ready, I will create a separate PR to add TOC for all TiUP docs.

tiup/tiup-component-cluster-audit.md Outdated

## Outputs

- If `[audit-id]` is specified, the corresponding execution log will be output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If `[audit-id]` is specified, the corresponding execution log will be output.
- If `[audit-id]` is specified, the corresponding execution log is output.

Please use the present tense in this PR.

@ran-huang
Copy link
Contributor

Please address this~ #5061 (comment)

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 1, 2021 •
edited
Loading

Addressed. PTAL again @ran-huang thx~

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39533aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2021
@ti-chi-bot ti-chi-bot merged commit 52f376b into pingcap:master Apr 1, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 1, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5061 to release-4.0
c0b60eb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5190

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 1, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5061 to release-5.0
beb9c75 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5191

ti-chi-bot pushed a commit that referenced this pull request Apr 1, 2021
@ti-srebot
tiup: add three docs (#5061) (#5190)
01aaabb
ti-chi-bot pushed a commit that referenced this pull request Apr 1, 2021
@ti-srebot
tiup: add three docs (#5061) (#5191)
bd26dfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@ran-huang ran-huang ran-huang approved these changes

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Joyinqin @lucklove @ran-huang @ti-chi-bot @ti-srebot @TomShawn @yikeke