Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variable: correct the heading level for a variable #5011

Merged
merged 1 commit into from
Mar 12, 2021
Merged

system-variable: correct the heading level for a variable #5011

merged 1 commit into from
Mar 12, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Correct the heading level for a variable.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2021
@TomShawn
Copy link
Contributor Author

/cc ran-huang
/label needs-cherry-pick-4.0 needs-cherry-pick-5.0
/size small
/status PTAL
/label require-LGT1

@ti-chi-bot ti-chi-bot requested a review from ran-huang March 11, 2021 08:56
@ti-chi-bot ti-chi-bot added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. labels Mar 11, 2021
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-4.0, needs-cherry-pick-5.0

@TomShawn
Copy link
Contributor Author

/translation done
/cc ran-huang

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2021
@TomShawn TomShawn mentioned this pull request Mar 11, 2021
Merged
10 tasks
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0

@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-4.0

@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@ran-huang
Copy link
Contributor

/label require-LGT1

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@ran-huang: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang
Copy link
Contributor

/cc Joyinqin

@ti-chi-bot ti-chi-bot requested a review from Joyinqin March 11, 2021 09:48
@Joyinqin
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Joyinqin
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3a7215e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-chi-bot ti-chi-bot merged commit 72404f9 into pingcap:master Mar 12, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 12, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5011 to release-4.0
def8fac 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 12, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5017

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 12, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5011 to release-5.0
f9fb249 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 12, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5018

@TomShawn TomShawn deleted the patch-1 branch March 12, 2021 02:48
ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2021
@ti-srebot
system-variable: correct the heading level for a variable (#5011) (#5017
eab6316 
)
ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2021
@ti-srebot
system-variable: correct the heading level for a variable (#5011) (#5018
b0bd55d 
)
This was referenced Mar 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang Awaiting requested review from ran-huang

@Joyinqin Joyinqin Awaiting requested review from Joyinqin

Assignees
No one assigned
Labels
size/small Changes of a small size. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ran-huang @ti-chi-bot @Joyinqin @ti-srebot