Log redact on TiFlash and PD (4.0) #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
added
translation/from-docs-cn
|
@JaySon-Huang, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack). |
ran-huang
reviewed
Mar 10, 2021
pd-configuration-file.md
Outdated
| ### `redact-info-log` <span class="version-mark">New in v4.0.10</span> | ||
|
|
||
| + Enables or disables log redaction in PD. | ||
| + If the configuration value is set to `true`, all user data in the PD log will be redacted. |
There was a problem hiding this comment.
Do you think we should align this with v5.0? https://docs.pingcap.com/tidb/v5.0/pd-configuration-file#redact-info-log-new-in-v500-rc
The description is not consistent.
There was a problem hiding this comment.
This is made inconsistent on purpose. This redact-info-log is introduced in v5.0.0-rc for dev/v5.0 and in v4.0.10 for v4.0. v5.0.0-rc is earlier than v4.0.10.
ran-huang
approved these changes
Mar 10, 2021
TomShawn
commented
Mar 10, 2021
TomShawn
added
needs-cherry-pick-master
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Mar 10, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
|
cherry pick to release-5.0 in PR #4999 |
TomShawn
removed
needs-cherry-pick-5.0
needs-cherry-pick-master
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Mar 10, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
|
cherry pick to master in PR #5000 |
TomShawn
added a commit
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
TiFlash and PD have picked the feature "redact-log" to the release-4.0 branch(released in 4.0.10), but forgot to add documents to the release-4.0 branch.
Add redact log configurations for TiFlash and PD.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?