Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in optimistic-transaction.md #4959

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix a typo in optimistic-transaction.md #4959

merged 2 commits into from
Mar 8, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 3, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

To close #4812.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. size/small Changes of a small size. needs-cherry-pick-2.1 status/PTAL This PR is ready for reviewing. labels Mar 3, 2021
@TomShawn TomShawn requested a review from cfzjywxk March 3, 2021 06:30
@TomShawn TomShawn self-assigned this Mar 3, 2021
@ti-srebot
Copy link
Contributor

@cfzjywxk, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@cfzjywxk, PTAL.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Mar 7, 2021

/lgtm

@ti-srebot
Copy link
Contributor

@cfzjywxk, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
@TomShawn TomShawn merged commit baf515d into master Mar 8, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 8, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4959 to release-2.1
552fd86 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4986

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 8, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4959 to release-3.0
5eb2a9c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4987

@TomShawn TomShawn deleted the TomShawn-patch-3 branch March 8, 2021 13:25
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 8, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4959 to release-3.1
06b1c1e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4988

TomShawn added a commit that referenced this pull request Mar 8, 2021
@ti-srebot @TomShawn
cherry pick #4959 to release-2.1 (#4986)
cdd4e70 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 8, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4959 to release-4.0
7fdba4f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4989

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 8, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4959 to release-5.0
19a347c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4990

TomShawn added a commit that referenced this pull request Mar 8, 2021
@ti-srebot @TomShawn
cherry pick #4959 to release-3.0 (#4987)
84f3410 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Mar 8, 2021
@ti-srebot @TomShawn
cherry pick #4959 to release-3.1 (#4988)
ad26ed8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Mar 9, 2021
@ti-srebot @TomShawn
cherry pick #4959 to release-4.0 (#4989)
a5e6ed0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Mar 9, 2021
@ti-srebot @TomShawn
cherry pick #4959 to release-5.0 (#4990)
d899958 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor Author

/remove-translation doing
/translation no-need

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 11, 2021
@TomShawn
Copy link
Contributor Author

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

correct miswriting
5 participants
@TomShawn @ti-srebot @cfzjywxk @CharLotteiu @ti-chi-bot