Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment-syntanx: move a misplaced sentence #4731

Merged
merged 1 commit into from
Jan 27, 2021
Merged

comment-syntanx: move a misplaced sentence #4731

merged 1 commit into from
Jan 27, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jan 27, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

comment-syntanx: move a misplaced sentence

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added needs-cherry-pick-3.1 translation/no-need No need to translate this PR. labels Jan 27, 2021
CharLotteiu
CharLotteiu approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@TomShawn TomShawn merged commit 427c0d2 into master Jan 27, 2021
@TomShawn TomShawn deleted the TomShawn-patch-2 branch January 27, 2021 10:03
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 27, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4731 to release-3.1
3f6dd81 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 27, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4732

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 27, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4731 to release-4.0
8b4715b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 27, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4733

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 27, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4731 to release-5.0
beb351e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 27, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4734

TomShawn added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @TomShawn
cherry pick #4731 to release-5.0 (#4734)
63713a1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @TomShawn
cherry pick #4731 to release-4.0 (#4733)
ce4bcca 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @TomShawn
cherry pick #4731 to release-3.1 (#4732)
d3d6ac9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Jan 27, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-srebot @CharLotteiu