Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine ecosystem tool guide document #4627

Merged
merged 1 commit into from
Jan 15, 2021
Merged

refine ecosystem tool guide document #4627

merged 1 commit into from
Jan 15, 2021

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jan 14, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

close #4606
mydumper note is misleading and inaccurate

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested a review from morgo January 15, 2021 04:20
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Jan 15, 2021
TomShawn
TomShawn approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2021
@TomShawn TomShawn merged commit 9fc212e into pingcap:master Jan 15, 2021
@TomShawn TomShawn removed the request for review from morgo January 15, 2021 07:54
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 15, 2021
@lichunzhu @ti-srebot
cherry pick pingcap#4627 to release-4.0
e3a9577 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4628

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 15, 2021
@lichunzhu @ti-srebot
cherry pick pingcap#4627 to release-5.0
0c0e4ec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4629

TomShawn pushed a commit that referenced this pull request Jan 15, 2021
@ti-srebot @lichunzhu
cherry pick #4627 to release-5.0 (#4629)
64afc82 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
TomShawn added a commit that referenced this pull request Jan 15, 2021
@ti-srebot @lichunzhu @TomShawn
refine ecosystem tool guide document (#4627) (#4628)
c6765bf 
* cherry pick #4627 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Apply suggestions from code review

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lichunzhu lichunzhu deleted the refineEcosystemToolGuide branch January 15, 2021 08:03
@Joyinqin Joyinqin mentioned this pull request Jan 21, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jan 21, 2021
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Jan 21, 2021
This was referenced Jan 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mydumper note is misleading and inaccurate
5 participants
@lichunzhu @CLAassistant @ti-srebot @Joyinqin @TomShawn