Skip to content

Added attention to online parameter changes #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2021
Merged

Added attention to online parameter changes #4607

merged 5 commits into from
Apr 22, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jan 13, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-4.0, needs-cherry-pick-5.0, size/small, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jan 13, 2021
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@ti-srebot ti-srebot requested a review from TomShawn January 13, 2021 02:25
TomShawn
TomShawn reviewed Jan 13, 2021
View reviewed changes
morgo
morgo reviewed Jan 13, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/small Changes of a small size. labels Apr 22, 2021
@xiongjiwei
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@xiongjiwei: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7322e59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@TomShawn
Copy link
Contributor

/rebase

Joyinqin and others added 5 commits April 22, 2021 11:33
@Joyinqin @TomShawn
Update dynamic-config.md
1a4e0fb
@Joyinqin @TomShawn
Update dynamic-config.md
f2a5bc0
@Joyinqin @TomShawn
Update dynamic-config.md
15a38a7
@Joyinqin @TomShawn
Apply suggestions from code review
e4b511e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin @TomShawn
Apply suggestions from code review
8908fa5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8908fa5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit ac07511 into pingcap:master Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#4607 to release-4.0
e09f46c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5436

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#4607 to release-5.0
86261a7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5437

ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
Added attention to online parameter changes (#4607) (#5436)
a3e2681
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
Added attention to online parameter changes (#4607) (#5437)
b08c3c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo left review comments

@xiongjiwei xiongjiwei xiongjiwei left review comments

@TomShawn TomShawn TomShawn left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Joyinqin @xiongjiwei @ti-chi-bot @TomShawn @ti-srebot @morgo