Skip to content

improve system-variables documentation #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 18, 2021
Merged

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jan 11, 2021

What is changed, added or deleted? (Required)

The system variables documentation is incomplete and out of date. This helps improve it, but there are still many issues.

The following issues were fixed:

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn
Copy link
Contributor

@morgo Would you please involve technical review first?

@TomShawn
Copy link
Contributor

pingcap/docs-cn#3975 is merged and its translation is under review: #4602. PTAL

@TomShawn TomShawn added needs-cherry-pick-5.0 status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Jan 13, 2021
@TomShawn TomShawn self-assigned this Jan 13, 2021
morgo and others added 2 commits January 12, 2021 23:18
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2021
@ti-srebot
Copy link
Contributor

@tangenta, PTAL.

morgo and others added 7 commits January 16, 2021 21:16
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 18, 2021
@pingcap pingcap deleted a comment from morgo Jan 18, 2021
@pingcap pingcap deleted a comment from morgo Jan 18, 2021
@TomShawn TomShawn merged commit 3339a09 into pingcap:master Jan 18, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 18, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4647

TomShawn pushed a commit that referenced this pull request Jan 18, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Morgan Tocker <tocker@gmail.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 19, 2021
@shichun-0415 shichun-0415 mentioned this pull request Feb 2, 2023
22 tasks
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants