-
Notifications
You must be signed in to change notification settings - Fork 694
improve system-variables documentation #4598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a8c03c
to
46ebfba
Compare
46ebfba
to
5a279f1
Compare
@morgo Would you please involve technical review first? |
pingcap/docs-cn#3975 is merged and its translation is under review: #4602. PTAL |
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tangenta, PTAL. |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #4647 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Morgan Tocker <tocker@gmail.com>
What is changed, added or deleted? (Required)
The system variables documentation is incomplete and out of date. This helps improve it, but there are still many issues.
The following issues were fixed:
TiDB executor concurrency is not documented (this was introduced in master and is an important setting. If Add doc for tidb_executor_concurrency docs-cn#3975 merges, the translation can be overwritten here.)The defaults for other executor concurrency options were incorrect. They also did not document if they were deprecated by executor concurrency.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?