Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd: add new configurations #4478

Merged
merged 4 commits into from
Dec 24, 2020
Merged

pd: add new configurations #4478

merged 4 commits into from
Dec 24, 2020

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add a new configuration region-score-formula-version and updated the default value of enable-cross-table-merge for v5.0.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CharLotteiu CharLotteiu added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Dec 23, 2020
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0. label Dec 23, 2020
TomShawn
TomShawn approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
@disksing PTAL

pd-configuration-file.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2020
CharLotteiu and others added 2 commits December 23, 2020 18:06
@CharLotteiu @TomShawn
Apply suggestions from code review
7bd3620 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Merge branch 'master' into upadte-config
f7b5400
disksing
disksing approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@disksing, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 94ad2b8 into pingcap:master Dec 24, 2020
@CharLotteiu CharLotteiu deleted the upadte-config branch July 9, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharLotteiu @ti-srebot @disksing @TomShawn