Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustered indexes: add initial docs #4476

Merged
merged 29 commits into from
Dec 29, 2020
Merged

clustered indexes: add initial docs #4476

merged 29 commits into from
Dec 29, 2020

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 22, 2020

First-time contributors' checklist

What is changed, added or deleted? (Required)

This adds the intial docs for clustered indexes, an experimental features in TiDB 5.0. There are no other docs about it yet.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

bb7133
bb7133 reviewed Dec 23, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@morgo @bb7133
Update clustered-indexes.md
b6dd2bc 
Co-authored-by: bb7133 <bb7133@gmail.com>
morgo
morgo commented Dec 23, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
morgo
morgo commented Dec 23, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@coocood
Copy link
Member

coocood commented Dec 23, 2020

LGTM

@ti-srebot
Copy link
Contributor

@coocood, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn added size/large Changes of a large size. translation/doing This PR's assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0. labels Dec 24, 2020
TomShawn
TomShawn reviewed Dec 24, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Dec 24, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
morgo and others added 5 commits December 23, 2020 21:35
@morgo @TomShawn
Update clustered-indexes.md
4d52321 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
57b0ff4 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo
Merge branch 'master' into clustered-indexes
0df8870
@morgo
Update clustered-indexes.md
2a36a87
@morgo
Fix broken anchor
960cf36
@morgo morgo force-pushed the clustered-indexes branch from 895e3bd to 960cf36 Compare December 24, 2020 04:59
TomShawn
TomShawn reviewed Dec 24, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Dec 24, 2020
morgo and others added 3 commits December 23, 2020 22:59
@morgo @TomShawn
Update clustered-indexes.md
48dc189 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
45c1713 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
f8058ef 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
morgo and others added 2 commits December 24, 2020 18:05
@morgo @TomShawn
Update clustered-indexes.md
5966e77 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Merge branch 'master' into clustered-indexes
4e55db2
@ti-srebot
Copy link
Contributor

@morgo, please update your pull request.

@lilin90 lilin90 requested a review from yikeke December 28, 2020 06:15
TomShawn
TomShawn reviewed Dec 28, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Show resolved Hide resolved
TomShawn
TomShawn reviewed Dec 28, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Dec 28, 2020
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
yikeke
yikeke reviewed Dec 28, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2020
morgo and others added 5 commits December 28, 2020 08:14
@morgo @TomShawn
Update clustered-indexes.md
c0289ba 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
aa2c848 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
1132bea 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
c3adf87 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update clustered-indexes.md
762c897 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2020
@TomShawn TomShawn merged commit aa37759 into pingcap:master Dec 29, 2020
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Dec 29, 2020
@CharLotteiu CharLotteiu mentioned this pull request Dec 29, 2020
Merged
10 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 29, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@yikeke yikeke yikeke left review comments

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@CharLotteiu CharLotteiu

Labels
size/large Changes of a large size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@morgo @coocood @ti-srebot @bb7133 @yikeke @TomShawn @CharLotteiu