Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine explanation for general log #4378

Merged
merged 4 commits into from
Dec 17, 2020
Merged

refine explanation for general log #4378

merged 4 commits into from
Dec 17, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Dec 10, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Add detailed description for tidb_general_log.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Dec 10, 2020
ran-huang
ran-huang reviewed Dec 10, 2020
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn @ran-huang
Update system-variables.md
d1f851b 
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2020
@ti-srebot
Copy link
Contributor

@ran-huang, @XuHuaiyu, PTAL.

@ti-srebot
Copy link
Contributor

@XuHuaiyu, PTAL.

XuHuaiyu
XuHuaiyu reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@XuHuaiyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit b747948 into pingcap:master Dec 17, 2020
@TomShawn TomShawn deleted the tidb-general-log branch December 17, 2020 06:12
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 17, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4378 to release-4.0
e7b311f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4425

TomShawn added a commit that referenced this pull request Dec 17, 2020
@ti-srebot @TomShawn
cherry pick #4378 to release-4.0 (#4425)
38672e3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lilin90 lilin90 mentioned this pull request Jan 24, 2021
Closed
@kolbe
Copy link
Contributor

kolbe commented Jan 27, 2021

Fixes #3720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ran-huang @ti-srebot @kolbe @XuHuaiyu