Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: doc updates for 4.0.9 #4334

Merged
merged 9 commits into from
Dec 21, 2020
Merged

ticdc: doc updates for 4.0.9 #4334

merged 9 commits into from
Dec 21, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Dec 4, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Added explanation about the --sort-engine parameter of a TiCDC changefeed.
  • Added information about Unified Sorter to the TiCDC trouble shooting FAQs.
  • Added documentation of max-batch-size.
  • Added extra explanation about max-message-bytes.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Dec 4, 2020
@TomShawn TomShawn requested review from liuzix and ran-huang December 4, 2020 08:55
@ti-srebot
Copy link
Contributor

@liuzix, @ran-huang, PTAL.

ran-huang
ran-huang reviewed Dec 7, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@TomShawn @ran-huang
Apply suggestions from code review
9c5c29c 
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
ran-huang reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2020
@ti-srebot
Copy link
Contributor

@ran-huang, @liuzix, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@ran-huang, @liuzix, PTAL.

liuzix
liuzix reviewed Dec 14, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
liuzix
liuzix reviewed Dec 14, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@TomShawn @liuzix
Apply suggestions from code review
b3f7f03 
Co-authored-by: Zixiong Liu <zl2683@columbia.edu>
liuzix
liuzix reviewed Dec 14, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
liuzix
liuzix reviewed Dec 14, 2020
View reviewed changes
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
liuzix
liuzix reviewed Dec 14, 2020
View reviewed changes
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
liuzix
liuzix suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@liuzix liuzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a few word choices

@TomShawn @liuzix
Apply suggestions from code review
9200f71 
Co-authored-by: Zixiong Liu <zl2683@columbia.edu>
@TomShawn
Copy link
Contributor Author

@liuzix Comments addressed, PTAL, thanks~

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 18, 2020
liuzix
liuzix suggested changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@liuzix liuzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me change these? We think this is the better way to direct users to solve the problem.

ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@TomShawn @liuzix
Apply suggestions from code review
e675a37 
Co-authored-by: Zixiong Liu <zl2683@columbia.edu>
@liuzix
Copy link
Contributor

liuzix commented Dec 18, 2020

LGTM

@ti-srebot
Copy link
Contributor

@liuzix, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn commented Dec 18, 2020
View reviewed changes
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@yikeke, @ti-srebot, PTAL.

@TomShawn TomShawn merged commit d612ffa into pingcap:master Dec 21, 2020
@TomShawn TomShawn deleted the ticdc-409 branch December 21, 2020 14:18
@TomShawn
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 21, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4334 to release-4.0
61f983a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4462

TomShawn added a commit that referenced this pull request Dec 21, 2020
@ti-srebot @TomShawn
cherry pick #4334 to release-4.0 (#4462)
d3ab650 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@liuzix liuzix liuzix requested changes

@yikeke yikeke yikeke approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-srebot @liuzix @yikeke @ran-huang