Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dbdeployer and homebrew deployment methods #4278

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Remove dbdeployer and homebrew deployment methods #4278

merged 2 commits into from
Nov 24, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 24, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Remove 2 obsolete documents: deploy-tidb-from-dbdeployer.md and deploy-tidb-from-homebrew.md (as confirmed with @nullnotnil)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/no-need No need to translate this PR. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Nov 24, 2020
@TomShawn TomShawn changed the title Remove 2 docs Remove dbdeployer and homebrew deployment methods Nov 24, 2020
@TomShawn TomShawn requested review from a user and lilin90 November 24, 2020 03:20
lilin90
lilin90 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2020
@TomShawn TomShawn removed the request for review from a user November 24, 2020 03:27
@TomShawn TomShawn merged commit 25681f9 into pingcap:master Nov 24, 2020
@TomShawn TomShawn deleted the remove-dbdeployer branch November 24, 2020 03:28
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 24, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4278 to release-4.0
7d51dd8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 24, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4280

TomShawn added a commit that referenced this pull request Nov 24, 2020
@ti-srebot @TomShawn
Remove dbdeployer and homebrew deployment methods (#4278) (#4280)
09bc696 
* cherry pick #4278 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflicts

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-srebot @lilin90