Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add how to dump to amazon s3 for dumpling #4193

Merged
merged 3 commits into from
Nov 10, 2020
Merged

add how to dump to amazon s3 for dumpling #4193

merged 3 commits into from
Nov 10, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 10, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

add how to dump to amazon s3 for dumpling

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Nov 10, 2020
@TomShawn TomShawn added size/small Changes of a small size. and removed size/medium Changes of a medium size. labels Nov 10, 2020
ran-huang
ran-huang reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dumpling-overview.md Outdated Show resolved Hide resolved
TomShawn and others added 2 commits November 10, 2020 14:08
lichunzhu
lichunzhu approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2020
@ran-huang
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 10, 2020
@TomShawn TomShawn merged commit eaceef1 into pingcap:master Nov 10, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 10, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4193 to release-4.0
87e8257 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 10, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4197

@TomShawn TomShawn deleted the dumpling-s3data branch November 10, 2020 06:45
TomShawn added a commit that referenced this pull request Nov 10, 2020
@ti-srebot @TomShawn
cherry pick #4193 to release-4.0 (#4197)
bb62644 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ran-huang @ti-srebot @lichunzhu