Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make information in explain-walkthrough.md more accurate #4090

Merged
2 commits merged into from
Oct 28, 2020
Merged

Make information in explain-walkthrough.md more accurate #4090

2 commits merged into from
Oct 28, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Oct 26, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Address comments from the Chinese translation pingcap/docs-cn#4685 to make information in explain-walkthrough.md more accurate.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Oct 26, 2020
@TomShawn TomShawn requested a review from zz-jason October 26, 2020 11:36
@TomShawn TomShawn self-assigned this Oct 26, 2020
@TomShawn TomShawn mentioned this pull request Oct 26, 2020
Merged
9 tasks
@TomShawn TomShawn requested a review from a user October 26, 2020 11:38
zz-jason
zz-jason reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 26, 2020
@ti-srebot
Copy link
Contributor

@zz-jason, @ti-srebot, @nullnotnil, PTAL.

@ghost ghost merged commit d6a1814 into master Oct 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Oct 28, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4090 to release-4.0
da39964 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 28, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4104

@TomShawn TomShawn deleted the TomShawn-patch-2 branch October 29, 2020 02:54
TomShawn added a commit that referenced this pull request Oct 29, 2020
@ti-srebot @TomShawn
cherry pick #4090 to release-4.0 (#4104)
f22cfd6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
9 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-srebot @zz-jason