Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine language for explain-walkthrough.md #4058

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Refine language for explain-walkthrough.md #4058

merged 2 commits into from
Oct 19, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Oct 15, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Refine language of explain-walkthrough.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Oct 15, 2020
@TomShawn TomShawn requested a review from lilin90 October 15, 2020 03:02
@TomShawn TomShawn self-assigned this Oct 15, 2020
@TomShawn TomShawn mentioned this pull request Oct 15, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

@lilin90, PTAL.

@ghost ghost self-requested a review October 19, 2020 02:03
ghost
ghost reviewed Oct 19, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2020
lilin90
lilin90 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2020
@lilin90
Copy link
Member

lilin90 commented Oct 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 181b02b into pingcap:master Oct 19, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Oct 19, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4058 to release-4.0
d73ee8a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 19, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4077

lilin90 pushed a commit that referenced this pull request Oct 19, 2020
@ti-srebot @TomShawn
cherry pick #4058 to release-4.0 (#4077)
f746e65 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the refine-lgg branch October 25, 2020 13:43
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-srebot @lilin90