Skip to content

pd: update placement rules #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2020
Merged

pd: update placement rules #3981

merged 7 commits into from
Oct 9, 2020

Conversation

Joyinqin
Copy link
Contributor

What is changed, added or deleted? (Required)

add the usage of the new add bundle API
remove the old load/save method

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label size/medium, v5.0, translation/from-docs-cn

@ti-srebot ti-srebot added size/medium Changes of a medium size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0. labels Sep 28, 2020
@Joyinqin
Copy link
Contributor Author

/cc TomShawn, disksing

@Joyinqin Joyinqin marked this pull request as ready for review September 29, 2020 08:29
TomShawn
TomShawn reviewed Sep 29, 2020
View reviewed changes
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Sep 30, 2020
@ti-srebot
Copy link
Contributor

@Joyinqin, please update your pull request.

@ti-srebot
Copy link
Contributor

@Joyinqin, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@Joyinqin, please update your pull request.

@Joyinqin @TomShawn
Apply suggestions from code review
adf3742 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Contributor

@disksing,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn reviewed Oct 9, 2020
View reviewed changes
TomShawn
TomShawn reviewed Oct 9, 2020
View reviewed changes
TomShawn
TomShawn reviewed Oct 9, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2020
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Oct 9, 2020
@TomShawn TomShawn merged commit df4fe27 into pingcap:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @ti-srebot @disksing @TomShawn