Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add system variable 'tidb_enable_clustered_index' for v5.0 #3907

Merged
merged 9 commits into from
Sep 16, 2020
Merged

add system variable 'tidb_enable_clustered_index' for v5.0 #3907

merged 9 commits into from
Sep 16, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Sep 14, 2020 •
edited by shichun-0415
Loading

What is changed, added or deleted? (Required)

add system variable 'tidb_enable_clustered_index' for v5.0
close #3155

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label size/medium, v5.0, translation/from-docs-cn

@ti-srebot ti-srebot added size/medium Changes of a medium size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0. labels Sep 14, 2020
@Joyinqin Joyinqin marked this pull request as ready for review September 15, 2020 01:57
@Joyinqin
Copy link
Contributor Author

/cc coocood, TomShawn

TomShawn
TomShawn reviewed Sep 15, 2020
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Sep 15, 2020
TomShawn
TomShawn reviewed Sep 16, 2020
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Sep 16, 2020
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@coocood
Copy link
Member

coocood commented Sep 16, 2020

LGTM

@ti-srebot
Copy link
Contributor

@coocood,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
TomShawn
TomShawn reviewed Sep 16, 2020
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn TomShawn merged commit 4e0126e into pingcap:master Sep 16, 2020
@shichun-0415 shichun-0415 mentioned this pull request Feb 2, 2023
Closed
22 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/medium Changes of a medium size. labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document missing system variables
5 participants
@Joyinqin @coocood @ti-srebot @TomShawn @ti-chi-bot