-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: add docs for local backend #3660
Conversation
@3pointer PTAL |
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL. |
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
@TomShawn, please update your pull request. |
@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL. |
@TomShawn, please update your pull request. |
@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL. |
@TomShawn, please update your pull request. |
@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL. |
What's the progress of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@overvenus I took a quick look, and think it's ready to merge. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #3755 |
* cherry pick #3660 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Update tidb-lightning/tidb-lightning-backends.md * Update tidb-lightning/tidb-lightning-backends.md * Delete tidb-lightning-tidb-backend.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
What is changed, added or deleted? (Required)
Add docs for lightning new feature
Local-Backend
that is in v4.0.3Change page
tidb-lightning-tidb-backend
totidb-lighting-backends
to include local backend. And update rhe reference in summery page.For reviewers of this PR:
The content of the newly created
tidb-lightning/tidb-lightning-backends.md
is moved from the deletedtidb-lightning/tidb-lightning-tidb-backend.md
and the deleted content oftidb-lightning/deploy-tidb-lightning.md
. New content in this file is very few. Hope this might make your review a bit easier.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?