Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: add docs for local backend #3660

Merged
merged 13 commits into from
Aug 27, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 13, 2020

What is changed, added or deleted? (Required)

Add docs for lightning new feature Local-Backend that is in v4.0.3

Change page tidb-lightning-tidb-backend to tidb-lighting-backends to include local backend. And update rhe reference in summery page.

For reviewers of this PR:

The content of the newly created tidb-lightning/tidb-lightning-backends.md is moved from the deleted tidb-lightning/tidb-lightning-tidb-backend.md and the deleted content of tidb-lightning/deploy-tidb-lightning.md. New content in this file is very few. Hope this might make your review a bit easier.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Aug 13, 2020
@TomShawn TomShawn requested review from overvenus, glorv and yikeke August 13, 2020 08:51
@glorv
Copy link
Contributor

glorv commented Aug 13, 2020

@3pointer PTAL

@yikeke yikeke requested a review from 3pointer August 14, 2020 05:57
ecosystem-tool-user-guide.md Outdated Show resolved Hide resolved
tidb-lightning/monitor-tidb-lightning.md Outdated Show resolved Hide resolved
tidb-lightning/monitor-tidb-lightning.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-faq.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-overview.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-overview.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-overview.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL.

tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-backends.md Outdated Show resolved Hide resolved
@yikeke yikeke added the status/require-change Needs the author to address comments. label Aug 18, 2020
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 19, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot
Copy link
Contributor

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Contributor

@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Contributor

@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Contributor

@yikeke, @glorv, @kennytm, @overvenus, @3pointer, PTAL.

@overvenus
Copy link
Member

What's the progress of this PR?

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2020
@lilin90
Copy link
Member

lilin90 commented Aug 27, 2020

What's the progress of this PR?

@overvenus I took a quick look, and think it's ready to merge.

@lilin90 lilin90 merged commit e48c88b into pingcap:master Aug 27, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3755

@TomShawn TomShawn deleted the local-backends-lightning branch August 27, 2020 10:57
lilin90 pushed a commit that referenced this pull request Aug 27, 2020
* cherry pick #3660 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update tidb-lightning/tidb-lightning-backends.md

* Update tidb-lightning/tidb-lightning-backends.md

* Delete tidb-lightning-tidb-backend.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants