Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple links to index and fix typos #3572

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Add multiple links to index and fix typos #3572

merged 3 commits into from
Aug 6, 2020

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Aug 6, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Add multiple links to _index.md
  • Fix multiple typos and update wording in encryption-at-rest.md
  • Update capitalization in TOC.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@lilin90 lilin90 added size/small Changes of a small size. translation/no-need No need to translate this PR. labels Aug 6, 2020
@lilin90 lilin90 requested a review from TomShawn August 6, 2020 12:25
TomShawn
TomShawn approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@lilin90 lilin90 added require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-4.0 labels Aug 6, 2020
@lilin90
Copy link
Member Author

lilin90 commented Aug 6, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit bc4cfb5 into pingcap:master Aug 6, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 6, 2020
@lilin90 @ti-srebot
cherry pick pingcap#3572 to release-4.0
7f56a8b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 6, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3573

@lilin90 lilin90 deleted the update-whats-new branch August 6, 2020 12:44
lilin90 added a commit that referenced this pull request Aug 6, 2020
@ti-srebot @lilin90
Add multiple links to index and fix typos (#3572) (#3573)
538ff67 
* cherry pick #3572 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update encryption-at-rest.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilin90 @ti-srebot @TomShawn