Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues in information schema docs (#3470) #3503

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix some issues in information schema docs (#3470) #3503

merged 1 commit into from
Aug 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3470 to release-4.0

What is changed, added or deleted? (Required)

  1. Fixes some issues from system-databases: Refactor/Improve clarity #3178 and system_tables: add column description for several tables #3322;
  2. Align update document for system-table-information-schema.md docs-cn#3470

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@yikeke @ti-srebot
cherry pick pingcap#3470 to release-4.0
ec79bcd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2020
Merged
9 tasks
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 3, 2020
@ti-srebot ti-srebot requested review from lilin90 and a user August 3, 2020 02:47
yikeke
yikeke approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@yikeke
Copy link
Contributor

yikeke commented Aug 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@yikeke yikeke merged commit 99fb642 into pingcap:release-4.0 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@yikeke yikeke

Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-srebot @yikeke