Update TiKV build guide #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ngaut
reviewed
Feb 14, 2018
dev-guide/development.md
Outdated
| ``` | ||
| ### Golang | ||
|
|
||
| Golang 1.8 or higher version is required. Please refer to [](https://golang.org/doc/install) to find how to install. |
Member
There was a problem hiding this comment.
We prefer 1.9 or higher version actually. Since users may want to use TiDB as well, and TiDB only support Go 1.9 or higher version.
Contributor
|
Thank you, @MyonKeminta for your contribution! @siddontang Please review, thanks! |
siddontang
reviewed
Feb 23, 2018
dev-guide/development.md
Outdated
| + Enter the source directory to build and install the binary in the `bin` directory. | ||
| ``` | ||
| # Get rustup from rustup.rs, then in your `tikv` folder: | ||
| $ rustup override set nightly-2018-01-12 |
siddontang
reviewed
Feb 23, 2018
dev-guide/development.md
Outdated
| ## Build TiKV | ||
|
|
||
| After you install the RocksDB shared library, you can build TiKV directly without `ROCKSDB_SYS_STATIC`. | ||
| ### Rust toolchain |
Member
There was a problem hiding this comment.
This is conflicted with https://github.com/MyonKeminta/docs/blob/1693df64c7d0278e26416bc271423000292e1a09/dev-guide/requirements.md#prerequisites, I think you should move these to the prerequisites.
Contributor
Author
|
@siddontang @ngaut PTAL |
|
@BusyJay PTAL |
|
LGTM |
BusyJay
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.