Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment-syntax.md (#3447) #3452

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update comment-syntax.md (#3447) #3452

merged 1 commit into from
Jul 28, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3447 to release-4.0

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway @ti-srebot
cherry pick pingcap#3447 to release-4.0
5925943 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
Merged
9 tasks
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 28, 2020
@ti-srebot ti-srebot requested review from tangenta and TomShawn July 28, 2020 09:22
ireneontheway
ireneontheway approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@ireneontheway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 458bad4 into pingcap:release-4.0 Jul 28, 2020
@ireneontheway ireneontheway deleted the release-4.0-bbebee2a267c branch July 28, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ireneontheway ireneontheway ireneontheway approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@ireneontheway ireneontheway

Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @ireneontheway @TomShawn