Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog: add new cmd flag #345

Merged
merged 3 commits into from
Mar 12, 2018
Merged

binlog: add new cmd flag #345

merged 3 commits into from
Mar 12, 2018

Conversation

IANTHEREAL
Copy link
Contributor

No description provided.

@@ -133,6 +133,8 @@ zookeeper_addrs = "192.168.0.11:2181,192.168.0.12:2181,192.168.0.13:2181"
to configure the file path of Pump; if you specifies the configuration file, Pump reads the configuration first; if the corresponding configuration also exists in the command line argument, Pump uses the command line configuration to cover that in the configuration file
-data-dir string
the path of storing Pump data
-enable-tolerant
after enable tolerant, pump wouldn't return error if it fails to write binlog (default true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • after enable -> after enabling
  • pump -> Pump

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 64843ac into master Mar 12, 2018
@lilin90 lilin90 deleted the ian/binlog branch March 12, 2018 11:57
lilin90 added a commit to lilin90/docs-cn that referenced this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants