Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: add options in pr template #3344

Merged
merged 4 commits into from
Jul 21, 2020
Merged

.github: add options in pr template #3344

merged 4 commits into from
Jul 21, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 20, 2020 •
edited by yikeke
Loading

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

  1. Add options in PR template to facilitate addressing the potential issues in cherry-picked PRs.
  2. Disabled 3 github actions because github actions won't work for PRs filed from forked repos, thus violating our standard procedures of sending PRs to upstream.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

ran-huang added 2 commits July 20, 2020 19:37
@ran-huang
.github: add options in pr template
dda2b6e 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
fix typo
c5c68d4
@ran-huang ran-huang requested review from yikeke and lilin90 July 20, 2020 11:42
@ran-huang ran-huang added needs-cherry-pick-2.1 translation/no-need No need to translate this PR. labels Jul 20, 2020
yikeke
yikeke approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 21, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@yikeke yikeke mentioned this pull request Jul 21, 2020
Merged
9 tasks
@ti-srebot ti-srebot merged commit e0e0f30 into pingcap:master Jul 21, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 21, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3344 to release-2.1
f5a0e99 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3349

@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 21, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 21, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3344 to release-3.0
a41bf0d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3350

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 21, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3344 to release-3.1
7dac0f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3351

@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
9 tasks
@ran-huang ran-huang deleted the update_pr_template branch July 21, 2020 02:42
ran-huang added a commit that referenced this pull request Jul 21, 2020
@ti-srebot @ran-huang
cherry pick #3344 to release-2.1 (#3349)
b21f586 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 21, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3344 to release-4.0
48a5d56 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3352

This was referenced Jul 21, 2020
Merged
Merged
Merged
ran-huang added a commit that referenced this pull request Jul 21, 2020
@ti-srebot @ran-huang
cherry pick #3344 to release-3.1 (#3351)
4f113b7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 21, 2020
@ti-srebot @ran-huang
cherry pick #3344 to release-3.0 (#3350)
9b2a706 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 21, 2020
@ti-srebot @ran-huang
cherry pick #3344 to release-4.0 (#3352)
fdbde87 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @yikeke @ti-srebot