Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expression-syntax.md #3288

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Update expression-syntax.md #3288

merged 5 commits into from
Jul 20, 2020

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ireneontheway
Copy link
Contributor Author

/label size/small, special-week, needs-cherry-pick-4.0, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. special-week PR from Document Special Week. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 16, 2020
@ireneontheway
Copy link
Contributor Author

@yikeke PTAL

@yikeke yikeke requested review from yikeke and tangenta July 16, 2020 12:15
tangenta
tangenta reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@tangenta,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

yikeke
yikeke reviewed Jul 17, 2020
View reviewed changes
expression-syntax.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

expression-syntax.md Outdated Show resolved Hide resolved
expression-syntax.md Outdated Show resolved Hide resolved
expression-syntax.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 17, 2020
ireneontheway and others added 2 commits July 20, 2020 10:17
@ireneontheway @yikeke
Apply suggestions from code review
b64b0fd 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ireneontheway
Merge branch 'master' into expression-syntax
0f5734d
@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@yikeke yikeke merged commit 1163b16 into pingcap:master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3288 to release-4.0
f75cdae 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3337

yikeke pushed a commit that referenced this pull request Jul 20, 2020
@ti-srebot @ireneontheway
cherry pick #3288 to release-4.0 (#3337)
c823f03 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ireneontheway @ti-srebot @yikeke @tangenta