Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aliases for tiflash deployment #3143

Merged
merged 1 commit into from
Jul 3, 2020
Merged

add aliases for tiflash deployment #3143

merged 1 commit into from
Jul 3, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

deploy-tiflash.md is reorganized as part of production-deployment-using-tiup.md.
This PR adds an alias for TiFlash deployment in production-deployment-using-tiup.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jul 3, 2020
@ran-huang ran-huang requested a review from CaitinChen July 3, 2020 11:19
@github-actions github-actions bot requested a review from TomShawn July 3, 2020 11:19
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 3, 2020
@ran-huang ran-huang added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 3, 2020
CaitinChen
CaitinChen approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
ti-srebot
ti-srebot approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@CaitinChen,Thanks for your review.

@CaitinChen CaitinChen merged commit 657fadd into master Jul 3, 2020
@CaitinChen CaitinChen deleted the ran-huang-patch-1 branch July 3, 2020 12:23
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3143 to release-4.0
267db57 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3144

ti-srebot added a commit that referenced this pull request Jul 3, 2020
@ti-srebot
add aliases for tiflash deployment (#3143) (#3144)
2f22352 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaitinChen CaitinChen CaitinChen approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-srebot @CaitinChen