Skip to content

update literal-values.md #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2020
Merged

update literal-values.md #3078

merged 4 commits into from
Jul 3, 2020

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jun 30, 2020 •
edited by yikeke
Loading

Signed-off-by: lucklove gnu.crazier@gmail.com

What is changed, added or deleted? (Required)

  • Add summary and correct some description in literal-values.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@lucklove
update literal-values.md
6bbbf62 
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove
Copy link
Member Author

Related PR: pingcap/docs-cn#3236

@yikeke yikeke requested a review from ran-huang June 30, 2020 09:21
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@yikeke yikeke requested a review from tangenta June 30, 2020 09:22
ran-huang
ran-huang reviewed Jul 1, 2020
View reviewed changes
@lucklove @ran-huang
Apply suggestions from code review
b9e68e5 
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor

@tangenta PTAL. Thanks!

ran-huang
ran-huang approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@ran-huang, @tangenta, PTAL.

tangenta
tangenta reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@tangenta, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lucklove merge failed.

@ran-huang
Copy link
Contributor

/merge

@ran-huang ran-huang removed status/PTAL This PR is ready for reviewing. status/can-merge Indicates a PR has been approved by a committer. labels Jul 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ran-huang ran-huang added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2020
@ti-srebot ti-srebot merged commit ff871af into pingcap:master Jul 3, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@lucklove @ti-srebot
cherry pick pingcap#3078 to release-3.0
6d562cd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3132

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@lucklove @ti-srebot
cherry pick pingcap#3078 to release-3.1
41a7e94 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3133

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@lucklove @ti-srebot
cherry pick pingcap#3078 to release-4.0
7bcb05f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3134

ran-huang pushed a commit that referenced this pull request Jul 3, 2020
@ti-srebot @lucklove
cherry pick #3078 to release-3.0 (#3132)
68684f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
ran-huang pushed a commit that referenced this pull request Jul 3, 2020
@ti-srebot @lucklove
cherry pick #3078 to release-3.1 (#3133)
ba1fa8d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
ran-huang pushed a commit that referenced this pull request Jul 3, 2020
@ti-srebot @lucklove
cherry pick #3078 to release-4.0 (#3134)
8f60f71 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucklove @ran-huang @ti-srebot @tangenta @yikeke