Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry docs #3062

Merged
merged 12 commits into from
Jun 30, 2020
Merged

Add telemetry docs #3062

merged 12 commits into from
Jun 30, 2020

Conversation

breezewish
Copy link
Member

What is changed, added or deleted? (Required)

This is the English version of pingcap/docs-cn#3812

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

TomShawn
TomShawn reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review
@breeswish Please address the comments and I'll review for the rest part.

dashboard/dashboard-intro.md Outdated Show resolved Hide resolved
dashboard/dashboard-intro.md Outdated Show resolved Hide resolved
offline-deployment-using-ansible.md Outdated Show resolved Hide resolved
online-deployment-using-ansible.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added needs-cherry-pick-4.0 size/large Changes of a large size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 29, 2020
TomShawn
TomShawn reviewed Jun 30, 2020
View reviewed changes
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-specific-system-variables.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

@july2993 @winkyao PTAL

breezewish and others added 3 commits June 30, 2020 14:37
@breezewish breezewish mentioned this pull request Jun 30, 2020
Merged
5 tasks
TomShawn
TomShawn reviewed Jun 30, 2020
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 422cf6f into master Jun 30, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 30, 2020
@breezewish @ti-srebot
cherry pick pingcap#3062 to release-4.0
7a6a6c9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3081

@breezewish breezewish deleted the telemetry branch June 30, 2020 07:53
TomShawn pushed a commit that referenced this pull request Jun 30, 2020
@ti-srebot @breezewish
Add telemetry docs (#3062) (#3081)
a6447a8 
* cherry pick #3062 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update production-deployment-using-tiup.md

Co-authored-by: Wenxuan <hi@breeswish.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@july2993 july2993 july2993 approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezewish @TomShawn @ti-srebot @july2993