Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tiflash configs and maintain-tiflash.md #3005

Merged
merged 4 commits into from
Jun 28, 2020
Merged

update tiflash configs and maintain-tiflash.md #3005

merged 4 commits into from
Jun 28, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

part of pingcap/docs-cn#3532,
pingcap/docs-cn#3599,
a link from pingcap/docs-cn#3341

  • Other reference link(s):

@github-actions github-actions bot requested a review from ilovesoup June 23, 2020 13:29
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 23, 2020
@yikeke yikeke removed request for ilovesoup and kissmydb June 23, 2020 13:29
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 23, 2020
@yikeke yikeke requested review from flowbehappy and removed request for zanmato1984 June 23, 2020 13:30
TomShawn
TomShawn approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

@yikeke @TomShawn
Apply suggestions from code review
6e7cad1 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jun 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4627248 into master Jun 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 28, 2020
@yikeke @ti-srebot
cherry pick pingcap#3005 to release-4.0
6226c8c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3044

ti-srebot added a commit that referenced this pull request Jun 28, 2020
@ti-srebot
update tiflash configs and maintain-tiflash.md (#3005) (#3044)
94ad717 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@yikeke yikeke deleted the update-tiflash-config branch June 28, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yikeke @ti-srebot @TomShawn