Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add tuing TiKV thread pool performance #2989

Merged
merged 9 commits into from
Jul 1, 2020

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jun 22, 2020

What is changed, added or deleted? (Required)

  • Add a new file: tune-tikv-thread-performance.md
  • Update TOC.md
  • Rename a file and update related links

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@lilin90 lilin90 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 22, 2020
@lilin90 lilin90 requested review from Little-Wallace and yikeke June 22, 2020 13:26
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. size/medium Changes of a medium size. labels Jun 23, 2020
@ti-srebot
Copy link
Contributor

@Little-Wallace, @yikeke, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@Little-Wallace, @yikeke, PTAL.

@lilin90
Copy link
Member Author

lilin90 commented Jun 30, 2020

@Little-Wallace PTAL

tune-tikv-memory-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
tune-tikv-thread-performance.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Jun 30, 2020

I fixed some small issues in the original Chinese text in pingcap/docs-cn#3817. Feel free to commit there if you have any other fix to make. @lilin90

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@lilin90
Copy link
Member Author

lilin90 commented Jun 30, 2020

@yikeke Thanks for your comments! All addressed. PTAL again~

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yikeke
Copy link
Contributor

yikeke commented Jul 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lilin90 lilin90 merged commit e554165 into pingcap:master Jul 1, 2020
@lilin90 lilin90 deleted the tikv-thread-pool branch July 1, 2020 06:15
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3099

yikeke added a commit that referenced this pull request Jul 1, 2020
* cherry pick #2989 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update tune-tikv-memory-performance.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants