Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dashboard images and remove outdated keyviz images #2944

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Update Dashboard images and remove outdated keyviz images #2944

merged 2 commits into from
Jun 19, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Update 16 Dashboard images and remove outdated keyviz images.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Jun 17, 2020
@TomShawn TomShawn requested review from breezewish and lilin90 June 17, 2020 14:01
@TomShawn TomShawn self-assigned this Jun 17, 2020
lilin90
lilin90 approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jun 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 5917a54 into pingcap:master Jun 19, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 19, 2020
@TomShawn @ti-srebot
cherry pick pingcap#2944 to release-4.0
26056c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2970

lilin90 pushed a commit that referenced this pull request Jun 19, 2020
@ti-srebot @TomShawn
cherry pick #2944 to release-4.0 (#2970)
d19f72f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the dashboard-imgs branch June 22, 2020 02:07
@TomShawn
Copy link
Contributor Author

/remove-translation doing
/translation no-need

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees

@TomShawn TomShawn

Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @lilin90 @ti-srebot @ti-chi-bot