Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outdated ansible deployment recommendations #2837

Merged
merged 3 commits into from
Jun 13, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 12, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@yikeke yikeke requested a review from lilin90 June 12, 2020 11:26
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 12, 2020
faq/tidb-faq.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Jun 12, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 12, 2020

/run-all-tests

@yikeke
Copy link
Contributor Author

yikeke commented Jun 13, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6861000 into pingcap:master Jun 13, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 13, 2020

cherry pick to release-4.0 in PR #2846

@yikeke yikeke deleted the update-tiup-docs branch June 13, 2020 04:11
sre-bot added a commit that referenced this pull request Jun 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants