Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

best-practice: update massive regions to match 4.0 #2595

Merged
merged 3 commits into from
May 27, 2020

Conversation

BusyJay
Copy link
Contributor

@BusyJay BusyJay commented May 19, 2020

What is changed, added or deleted? (Required)

Update massive regions to match 4.0.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@sre-bot sre-bot added the special-week PR from Document Special Week. label May 19, 2020
@TomShawn TomShawn added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label May 19, 2020
@TomShawn TomShawn requested review from kissmydb and lilin90 May 20, 2020 03:35
@lilin90 lilin90 removed the request for review from TomShawn May 20, 2020 04:04
@lilin90 lilin90 removed their request for review May 20, 2020 08:12
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot added status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 21, 2020
@sre-bot sre-bot requested a review from miaoqingli May 21, 2020 03:44
@TomShawn TomShawn self-requested a review May 21, 2020 12:35
@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2020

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2020

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@overvenus PTAL

@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2020

Copy link

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87 zhangjinpeng87 added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3e28802 into pingcap:docs-special-week May 27, 2020
@BusyJay BusyJay deleted the update-massive-regions branch May 27, 2020 06:05
yikeke added a commit that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* Move TiFlash troubleshoot part to a new document (#2602)

* best-practice: update massive regions to match 4.0 (#2595)

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] (#2618)

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: lei yu <leiysky@outlook.com>
Co-authored-by: Jay <BusyJay@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
@TomShawn TomShawn self-requested a review May 31, 2020 04:01
@yikeke
Copy link
Contributor

yikeke commented Jun 19, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #2969

@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 19, 2020
ti-srebot added a commit that referenced this pull request Jun 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants