master: add new resource-control TiKV configs by mittalrishabh · Pull Request #23035 · pingcap/docs

mittalrishabh · 2026-06-10T23:21:50Z

Add 11 new configuration parameters to the resource-control section introduced by TiKV PRs cherry-picked into the v8.5.7 release:

bg-cpu-throttle-threshold / fg-cpu-throttle-threshold (CPU throttling)
bg-compaction-pressure-threshold / bg-write-io-ceiling / bg-write-io-floor (I/O throttling)
enable-fair-scheduling / enable-read-admission-control / enable-write-admission-control
historical-usage-window-mins / baseline-burst-pct / admission-max-delayed-count

First-time contributors' checklist

I've signed the Contributor License Agreement, which is required for the repository owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2026-06-10T23:22:00Z

Hi @mittalrishabh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pingcap-cla-assistant · 2026-06-10T23:22:03Z

All committers have signed the CLA.

gemini-code-assist

Code Review

This pull request adds documentation for several new TiKV configuration items introduced in v8.5.6 and v9.0.0, including CPU throttling thresholds, write I/O limits, fair scheduling, and admission control settings. The review feedback suggests style improvements across all these additions to adhere to the repository style guide, specifically by replacing passive voice with active voice, using the second person ("you") when addressing users, and standardizing formatting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

ti-chi-bot · 2026-06-26T02:28:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lilin90 · 2026-06-29T10:11:43Z

/ok-to-test

lilin90 · 2026-06-29T10:21:39Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ lilin90✅ mittalrishabh❌ rishabh mittal

rishabh mittal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @mittalrishabh, it looks like the CLA bot cannot associate the email address used in your commit with a GitHub account. Related commits: 1e3ffcb, eebd83f.

Could you please check that the email address used for your commit has been added and verified in your GitHub account (Settings → Emails)? If the commit was created with a different email address, please amend the commit with the correct email and force-push the updated commit. The CLA check should then pass automatically.

Signed-off-by: rishabh mittal <mittalrishabh@gmail.com>

lilin90

Update anchor links

Synced from: pingcap/docs#23035 Target PR: pingcap#21754 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

v01dstar · 2026-07-03T05:54:39Z

+
+### `historical-usage-window-mins` <span class="version-mark">New in v8.5.7 and v9.0.0</span>
+
+ Specifies the size of the sliding time window (in minutes) that TiKV uses to compute per-resource-group historical RU baselines. A larger window smooths out short-term bursts, while a smaller window makes the baseline more responsive to recent usage. Valid range: `2-60`. **You must restart TiKV for changes to this configuration to take effect.**


I just realized that we don't validate the config in the code, although it says valid range is 2-60. I think we can merge this doc. And the validation in a PR later.

v01dstar

lgtm

ti-chi-bot · 2026-07-03T05:54:52Z

@v01dstar: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

v01dstar · 2026-07-03T06:05:54Z

+
+### `enable-write-admission-control` <span class="version-mark">New in v8.5.7 and v9.0.0</span>
+
+ Controls whether to enable admission control for write requests. When enabled, write requests from over-baseline resource groups are delayed or rejected with `SchedTooBusy` when CPU utilization exceeds [`fg-cpu-throttle-threshold`](#fg-cpu-throttle-threshold-new-in-v857-and-v900). This configuration takes effect only when [`enable-fair-scheduling`](#enable-fair-scheduling-new-in-v857-and-v900) is also enabled.


This configuration takes effect only when enable-fair-scheduling is also enabled.

AI thinks this is not the case. The test test_admission_decision() is the evidence.

ti-chi-bot Bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 10, 2026

ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Jun 10, 2026

ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2026

gemini-code-assist Bot reviewed Jun 10, 2026

View reviewed changes

lilin90 changed the title ~~tikv config: document new resource-control configs for v8.5.6~~ master: add new resource-control TiKV configs Jun 26, 2026

lilin90 self-assigned this Jun 26, 2026

lilin90 added the translation/doing This PR's assignee is translating this PR. label Jun 26, 2026

ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jun 26, 2026

lilin90 added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jun 26, 2026

lilin90 reviewed Jun 26, 2026

View reviewed changes

ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 29, 2026

tikv config: document new resource-control configs for v8.5.7

201863d

Signed-off-by: rishabh mittal <mittalrishabh@gmail.com>

mittalrishabh force-pushed the tikv-8.5-resource-control-configs branch from d30f984 to 201863d Compare June 30, 2026 23:52

lilin90 reviewed Jul 1, 2026

View reviewed changes

Update anchor links

d9312e8

lilin90 added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 1, 2026

lilin90 mentioned this pull request Jul 1, 2026

master: add new resource-control TiKV configs pingcap/docs-cn#21754

Open

12 tasks

lilin90 requested a review from v01dstar July 1, 2026 07:15

lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 1, 2026

lilin90 reviewed Jul 1, 2026

View reviewed changes

Comment thread tikv-configuration-file.md Outdated

Apply suggestions from code review

0569bbc

v01dstar reviewed Jul 3, 2026

View reviewed changes

v01dstar approved these changes Jul 3, 2026

View reviewed changes

v01dstar reviewed Jul 3, 2026

View reviewed changes


		### `historical-usage-window-mins` <span class="version-mark">New in v8.5.7 and v9.0.0</span>

		+ Specifies the size of the sliding time window (in minutes) that TiKV uses to compute per-resource-group historical RU baselines. A larger window smooths out short-term bursts, while a smaller window makes the baseline more responsive to recent usage. Valid range: `2-60`. You must restart TiKV for changes to this configuration to take effect.


		### `enable-write-admission-control` <span class="version-mark">New in v8.5.7 and v9.0.0</span>

		+ Controls whether to enable admission control for write requests. When enabled, write requests from over-baseline resource groups are delayed or rejected with `SchedTooBusy` when CPU utilization exceeds [`fg-cpu-throttle-threshold`](#fg-cpu-throttle-threshold-new-in-v857-and-v900). This configuration takes effect only when [`enable-fair-scheduling`](#enable-fair-scheduling-new-in-v857-and-v900) is also enabled.

Uh oh!

Conversation

mittalrishabh commented Jun 10, 2026 • edited by lilin90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot Bot commented Jun 10, 2026

Uh oh!

pingcap-cla-assistant Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jun 26, 2026

Uh oh!

lilin90 commented Jun 29, 2026

Uh oh!

lilin90 commented Jun 29, 2026

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v01dstar Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

v01dstar left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Jul 3, 2026

Uh oh!

v01dstar Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mittalrishabh commented Jun 10, 2026 •

edited by lilin90

Loading

pingcap-cla-assistant Bot commented Jun 10, 2026 •

edited

Loading

v01dstar Jul 3, 2026 •

edited

Loading